ob/sprint
1
0
Fork 0
mirror of https://github.com/hex248/sprint.git synced 2026-02-08 02:33:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: url params (SelectionProvider) weren't populating in the right places and and the right times

Browse Source
This commit is contained in:
Oliver Bryan
2026-01-28 08:58:07 +00:00
parent a4a9775779
commit 5fb806b5e8
2 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/frontend/src/components/selection-provider.tsx
View File

@@ -1,6 +1,7 @@
import type { IssueResponse, OrganisationResponse, ProjectResponse } from "@sprint/shared";
import type { ReactNode } from "react";
import { createContext, useCallback, useContext, useEffect, useMemo, useState } from "react";
import { useLocation } from "react-router-dom";
type SelectionContextValue = {
selectedOrganisationId: number | null;
@@ -69,6 +70,8 @@ const updateUrlParams = (updates: {
};
export function SelectionProvider({ children }: { children: ReactNode }) {
const location = useLocation();
const initialParams = useMemo(() => {
const params = new URLSearchParams(window.location.search);
const orgSlug = params.get("o")?.trim().toLowerCase() ?? "";
@@ -153,24 +156,25 @@ export function SelectionProvider({ children }: { children: ReactNode }) {
useEffect(() => {
const params = new URLSearchParams(window.location.search);
const allowIssue = window.location.pathname.startsWith("/issues");
const pathname = location.pathname;
const allowParams = pathname.startsWith("/issues") || pathname.startsWith("/timeline");
const updates: {
orgSlug?: string | null;
projectKey?: string | null;
issueNumber?: number | null;
} = {};
if (!params.get("o")) {
if (allowParams && !params.get("o")) {
const storedOrgSlug = readStoredString("selectedOrganisationSlug");
if (storedOrgSlug) updates.orgSlug = storedOrgSlug;
}
if (!params.get("p")) {
if (allowParams && !params.get("p")) {
const storedProjectKey = readStoredString("selectedProjectKey");
if (storedProjectKey) updates.projectKey = storedProjectKey;
}
if (allowIssue && !params.get("i")) {
if (allowParams && !params.get("i")) {
const storedIssueNumber = readStoredId("selectedIssueNumber");
if (storedIssueNumber != null) updates.issueNumber = storedIssueNumber;
}
@@ -178,7 +182,7 @@ export function SelectionProvider({ children }: { children: ReactNode }) {
if (Object.keys(updates).length > 0) {
updateUrlParams(updates);
}
}, []);
}, [location.pathname]);
const value = useMemo<SelectionContextValue>(
() => ({