improved select styling

packages/frontend/src/components/ui/select.tsx

@@ -1,25 +1,19 @@
-import * as React from "react"
+import * as SelectPrimitive from "@radix-ui/react-select";
-import * as SelectPrimitive from "@radix-ui/react-select"
+import { CheckIcon, ChevronDownIcon, ChevronUpIcon } from "lucide-react";
-import { CheckIcon, ChevronDownIcon, ChevronUpIcon } from "lucide-react"
+import type * as React from "react";
 
-import { cn } from "@/lib/utils"
+import { cn } from "@/lib/utils";
 
-function Select({
+function Select({ ...props }: React.ComponentProps<typeof SelectPrimitive.Root>) {
-  ...props
+    return <SelectPrimitive.Root data-slot="select" {...props} />;
-}: React.ComponentProps<typeof SelectPrimitive.Root>) {
-  return <SelectPrimitive.Root data-slot="select" {...props} />
 }
 
-function SelectGroup({
+function SelectGroup({ ...props }: React.ComponentProps<typeof SelectPrimitive.Group>) {
-  ...props
+    return <SelectPrimitive.Group data-slot="select-group" {...props} />;
-}: React.ComponentProps<typeof SelectPrimitive.Group>) {
-  return <SelectPrimitive.Group data-slot="select-group" {...props} />
 }
 
-function SelectValue({
+function SelectValue({ ...props }: React.ComponentProps<typeof SelectPrimitive.Value>) {
-  ...props
+    return <SelectPrimitive.Value data-slot="select-value" {...props} />;
-}: React.ComponentProps<typeof SelectPrimitive.Value>) {
-  return <SelectPrimitive.Value data-slot="select-value" {...props} />
 }
 
 function SelectTrigger({
@@ -28,15 +22,25 @@ function SelectTrigger({
     children,
     ...props
 }: React.ComponentProps<typeof SelectPrimitive.Trigger> & {
-  size?: "sm" | "default"
+    size?: "sm" | "default";
 }) {
     return (
         <SelectPrimitive.Trigger
             data-slot="select-trigger"
             data-size={size}
             className={cn(
-        "border-input data-[placeholder]:text-muted-foreground [&_svg:not([class*='text-'])]:text-muted-foreground focus-visible:border-ring focus-visible:ring-ring/50 aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40 aria-invalid:border-destructive dark:bg-input/30 dark:hover:bg-input/50 flex w-fit items-center justify-between gap-2 rounded-md border bg-transparent px-3 py-2 text-sm whitespace-nowrap shadow-xs transition-[color,box-shadow] outline-none focus-visible:ring-[3px] disabled:cursor-not-allowed disabled:opacity-50 data-[size=default]:h-9 data-[size=sm]:h-8 *:data-[slot=select-value]:line-clamp-1 *:data-[slot=select-value]:flex *:data-[slot=select-value]:items-center *:data-[slot=select-value]:gap-2 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
+                "cursor-pointer border data-[placeholder]:text-muted-foreground",
-        className
+                "[&_svg:not([class*='text-'])]:text-muted-foreground",
+                "aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40",
+                "aria-invalid:border-destructive dark:hover:bg-muted/40",
+                "flex w-fit items-center justify-between gap-2 border",
+                "bg-transparent px-3 py-2 text-sm whitespace-nowrap",
+                "shadow-xs transition-[color,box-shadow] outline-none disabled:cursor-not-allowed",
+                "disabled:opacity-50 data-[size=default]:h-9 data-[size=sm]:h-8",
+                "*:data-[slot=select-value]:line-clamp-1 *:data-[slot=select-value]:flex",
+                "*:data-[slot=select-value]:items-center *:data-[slot=select-value]:gap-2",
+                "[&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
+                className,
             )}
             {...props}
         >
@@ -45,7 +49,7 @@ function SelectTrigger({
                 <ChevronDownIcon className="size-4 opacity-50" />
             </SelectPrimitive.Icon>
         </SelectPrimitive.Trigger>
-  )
+    );
 }
 
 function SelectContent({
@@ -60,10 +64,18 @@ function SelectContent({
             <SelectPrimitive.Content
                 data-slot="select-content"
                 className={cn(
-          "bg-popover text-popover-foreground data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 relative z-50 max-h-(--radix-select-content-available-height) min-w-[8rem] origin-(--radix-select-content-transform-origin) overflow-x-hidden overflow-y-auto rounded-md border shadow-md",
+                    "bg-popover text-popover-foreground data-[state=open]:animate-in",
+                    "data-[state=closed]:animate-out data-[state=closed]:fade-out-0",
+                    "data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95",
+                    "data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2",
+                    "data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2",
+                    "data-[side=top]:slide-in-from-bottom-2 relative z-50",
+                    "max-h-(--radix-select-content-available-height) min-w-[8rem]",
+                    "origin-(--radix-select-content-transform-origin) overflow-x-hidden",
+                    "overflow-y-auto border shadow-md",
                     position === "popper" &&
-            "data-[side=bottom]:translate-y-1 data-[side=left]:-translate-x-1 data-[side=right]:translate-x-1 data-[side=top]:-translate-y-1",
+                        "data-[side=bottom]:translate-y-1 data-[side=bottom]:-translate-x-0.5 data-[side=left]:-translate-x-1 data-[side=right]:translate-x-1 data-[side=top]:-translate-y-1 data-[side=top]:-translate-x-0.5",
-          className
+                    className,
                 )}
                 position={position}
                 align={align}
@@ -74,7 +86,7 @@ function SelectContent({
                     className={cn(
                         "p-1",
                         position === "popper" &&
-              "h-[var(--radix-select-trigger-height)] w-full min-w-[var(--radix-select-trigger-width)] scroll-my-1"
+                            "h-[var(--radix-select-trigger-height)] w-full min-w-[var(--radix-select-trigger-width)] scroll-my-1",
                     )}
                 >
                     {children}
@@ -82,33 +94,32 @@ function SelectContent({
                 <SelectScrollDownButton />
             </SelectPrimitive.Content>
         </SelectPrimitive.Portal>
-  )
+    );
 }
 
-function SelectLabel({
+function SelectLabel({ className, ...props }: React.ComponentProps<typeof SelectPrimitive.Label>) {
-  className,
-  ...props
-}: React.ComponentProps<typeof SelectPrimitive.Label>) {
     return (
         <SelectPrimitive.Label
             data-slot="select-label"
             className={cn("text-muted-foreground px-2 py-1.5 text-xs", className)}
             {...props}
         />
-  )
+    );
 }
 
-function SelectItem({
+function SelectItem({ className, children, ...props }: React.ComponentProps<typeof SelectPrimitive.Item>) {
-  className,
-  children,
-  ...props
-}: React.ComponentProps<typeof SelectPrimitive.Item>) {
     return (
         <SelectPrimitive.Item
             data-slot="select-item"
             className={cn(
-        "focus:bg-accent focus:text-accent-foreground [&_svg:not([class*='text-'])]:text-muted-foreground relative flex w-full cursor-default items-center gap-2 rounded-sm py-1.5 pr-8 pl-2 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4 *:[span]:last:flex *:[span]:last:items-center *:[span]:last:gap-2",
+                "focus:bg-accent/40 focus:text-accent-foreground",
-        className
+                "[&_svg:not([class*='text-'])]:text-muted-foreground relative",
+                "flex w-full cursor-pointer items-center gap-2 py-1.5 pr-8 pl-2",
+                "text-sm outline-hidden select-none data-[disabled]:pointer-events-none",
+                "data-[disabled]:opacity-50 [&_svg]:pointer-events-none",
+                "[&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
+                "*:[span]:last:flex *:[span]:last:items-center *:[span]:last:gap-2",
+                className,
             )}
             {...props}
         >
@@ -122,20 +133,17 @@ function SelectItem({
             </span>
             <SelectPrimitive.ItemText>{children}</SelectPrimitive.ItemText>
         </SelectPrimitive.Item>
-  )
+    );
 }
 
-function SelectSeparator({
+function SelectSeparator({ className, ...props }: React.ComponentProps<typeof SelectPrimitive.Separator>) {
-  className,
-  ...props
-}: React.ComponentProps<typeof SelectPrimitive.Separator>) {
     return (
         <SelectPrimitive.Separator
             data-slot="select-separator"
             className={cn("bg-border pointer-events-none -mx-1 my-1 h-px", className)}
             {...props}
         />
-  )
+    );
 }
 
 function SelectScrollUpButton({
@@ -145,15 +153,12 @@ function SelectScrollUpButton({
     return (
         <SelectPrimitive.ScrollUpButton
             data-slot="select-scroll-up-button"
-      className={cn(
+            className={cn("flex cursor-default items-center justify-center py-1", className)}
-        "flex cursor-default items-center justify-center py-1",
-        className
-      )}
             {...props}
         >
             <ChevronUpIcon className="size-4" />
         </SelectPrimitive.ScrollUpButton>
-  )
+    );
 }
 
 function SelectScrollDownButton({
@@ -163,15 +168,12 @@ function SelectScrollDownButton({
     return (
         <SelectPrimitive.ScrollDownButton
             data-slot="select-scroll-down-button"
-      className={cn(
+            className={cn("flex cursor-default items-center justify-center py-1", className)}
-        "flex cursor-default items-center justify-center py-1",
-        className
-      )}
             {...props}
         >
             <ChevronDownIcon className="size-4" />
         </SelectPrimitive.ScrollDownButton>
-  )
+    );
 }
 
 export {
@@ -185,4 +187,4 @@ export {
     SelectSeparator,
     SelectTrigger,
     SelectValue,
-}
+};

packages/frontend/src/components/ui/table.tsx

@@ -39,7 +39,7 @@ function TableRow({
         <tr
             data-slot="table-row"
             className={cn(
-                "data-[state=selected]:bg-muted border-b transition-colors",
+                "data-[state=selected]:bg-muted border-b",
                 hoverEffect && "hover:bg-muted/40",
                 className,
             )}