From e53bba06d0e9def1c1e26e65dced1ee61ea065db Mon Sep 17 00:00:00 2001
From: Oliver Bryan <04oliverbryan@gmail.com>
Date: Mon, 12 Jan 2026 00:55:47 +0000
Subject: [PATCH] added "asChild" for trigger and type="button", not submit

prevents dialogs being closed by accident
---
 packages/frontend/src/components/ui/colour-picker.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/frontend/src/components/ui/colour-picker.tsx b/packages/frontend/src/components/ui/colour-picker.tsx
index d1573f4..68e1640 100644
--- a/packages/frontend/src/components/ui/colour-picker.tsx
+++ b/packages/frontend/src/components/ui/colour-picker.tsx
@@ -12,8 +12,8 @@ export default function ColourPicker({
 }) {
     return (
         <Popover>
-            <PopoverTrigger>
-                <Button className="w-8 h-8" style={{ backgroundColor: colour }}></Button>
+            <PopoverTrigger asChild>
+                <Button type="button" className="w-8 h-8" style={{ backgroundColor: colour }} />
             </PopoverTrigger>
             <PopoverContent className="w-fit grid gap-2 p-2" align="start" side={"top"}>
                 <HexColorPicker color={colour} onChange={onChange} className="p-0 m-0" />